Include model action fields in htmx requests#17
Conversation
|
Warning Review limit reached
More reviews will be available in 18 minutes and 6 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e35e717fd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <button class="btn btn--small {{if eq .Policy "free_verified"}}btn--ghost{{else}}btn--primary{{end}}" | ||
| hx-post="/models/check" | ||
| hx-include="#models-filters, closest [data-model-card]" | ||
| hx-include="#models-filters, closest .model-actions" |
There was a problem hiding this comment.
With the htmx 2.0.3 version pinned by the Dockerfile, extended selectors are only recognized when the whole hx-include value starts with closest; #models-filters, closest .model-actions is treated as a normal CSS selector list, so it matches the filter form but not the local action block. As a result the hidden model_id/provider inputs are still omitted for Check free/eval/override clicks, and the handlers keep returning model_id required; split/inherit the includes so .model-actions is actually serialized.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests